Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new experimental sharded checkpointer from OLMo-core #532

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Apr 1, 2024

This works a lot like the "torch_new" checkpointer where each rank only downloads the exact amount of data it needs and you can load a checkpoint with a different distributed topology, but without the additional GPU memory overhead.

For now we'll have to rely on installing the OLMo-core package directly from GitHub.

@epwalsh epwalsh requested a review from dirkgr April 1, 2024 22:05
Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By itself, this seems good. The main question is, is olmo-core ready for prime-time?

@epwalsh
Copy link
Member Author

epwalsh commented Apr 2, 2024

The main question is, is olmo-core ready for prime-time?

Probably not, but this will be a good stress test.

@epwalsh epwalsh merged commit 4792f94 into main Apr 2, 2024
10 of 11 checks passed
@epwalsh epwalsh deleted the epwalsh/olmo-core branch April 2, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants